[wp-trac] [WordPress Trac] #38678: Video Headers: Improve Basic Accessibility

[WordPress Trac]

#38678: Video Headers: Improve Basic Accessibility
------------------------------------+----------------------------
 Reporter:  davidakennedy           |       Owner:  joemcgill
     Type:  defect (bug)            |      Status:  assigned
 Priority:  normal                  |   Milestone:  4.7
Component:  Themes                  |     Version:
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:  accessibility
------------------------------------+----------------------------
Changes (by joemcgill):

 * keywords:  has-patch => has-patch dev-feedback
 * owner:   => joemcgill
 * status:  new => assigned


Comment:

 Generally, I think we should include a default style for the play/pause
 button that is always visible so the default experience promotes
 accessibility best practices without the need for themes to do anything
 other than call `the_custom_header_markup()`. This is not just a keyboard
 control a11y issue, it also assists people who become
 distracted/disoriented by motion. See: https://www.w3.org/TR
 /UNDERSTANDING-WCAG20/time-limits-pause.html

 @bradyvercher [attachment:38678.1.diff] Looks to include several nice
 improvements. A few questions about the approach:

 * What are the benefits for switching to constructors for rather than
 methods for handler callbacks?
 * Why are we triggering play/pause events on the video container rather
 than relying on the play/pause events of the video itself? Is it to
 provide consistent events regardless of the player used (e.g. YouTube) or
 did you have something else in mind?

 Also, a few nit-picks:

 * CustomHeader has a `header` variable defined that is never used.
 * The YT object needs to be defined somewhere, rather than assuming it's
 available in the window.
 * "native" is a JavaScript reserved word so we need a different name for
 that handler variable.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38678#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform