[wp-trac] [WordPress Trac] #38442: Error when WP_Query parses orderby array in function parse_order

WordPress Trac noreply at wordpress.org
Fri Nov 11 08:33:35 UTC 2016


#38442: Error when WP_Query parses orderby array in function parse_order
-------------------------------------------------+-------------------------
 Reporter:  oloynet                              |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Query                                |  Review
 Severity:  normal                               |     Version:  4.6.1
 Keywords:  has-patch 2nd-opinion needs-unit-    |  Resolution:
  tests                                          |     Focuses:
-------------------------------------------------+-------------------------
Changes (by swissspidy):

 * keywords:  has-patch 2nd-opinion => has-patch 2nd-opinion needs-unit-
               tests
 * severity:  major => normal


Comment:

 Hey there,

 Thank you very much for your report and welcome to WordPress Trac! The
 change looks reasonable at first glance.

 It would be nice to have [https://make.wordpress.org/core/handbook/testing
 /automated-testing/ unit tests] showing this bug and how the patch
 resolves it. Also, the patch should
 [https://make.wordpress.org/core/handbook/tutorials/working-with-patches/
 ideally] have a `.patch` or `.diff` extension and not contain any `start
 patch` and `end patch` comments.

 Let me know if you're familiar with automated testing or not. I'm sure
 someone else might be able to step up here.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38442#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list