[wp-trac] [WordPress Trac] #38651: Customizer edit icons may be partially off-screen in Device Preview mode

WordPress Trac noreply at wordpress.org
Fri Nov 11 03:57:09 UTC 2016


#38651: Customizer edit icons may be partially off-screen in Device Preview mode
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:  sirbrillig
     Type:  defect (bug)                         |      Status:  assigned
 Priority:  normal                               |   Milestone:  4.7
Component:  Customize                            |     Version:  trunk
 Severity:  normal                               |  Resolution:
 Keywords:  has-screenshots has-patch reporter-  |     Focuses:
  feedback 2nd-opinion                           |
-------------------------------------------------+-------------------------

Comment (by sirbrillig):

 Uploaded a new version of the patch without the theme-specific changes.
 Here's a very rough draft of a possible commit message (never written one
 for core before, so please take with a grain of salt):

 Customizer: Remove left-margin guard from edit shortcuts and adjust for
 small widths

 Removes the `.customize-partial-edit-shortcut-left-margin` class which was
 not effective on some themes, created a worse experience for some themes,
 and which did not recalculate when the preview was reflowed or resized.
 Instead some small width media queries were added to handle common cases
 while more dramatic issues can be handled by the theme.

 Also renames `Partial.positionEditShortcut()`to
 `Partial.addEditShortcutToPlacement()` which is a more accurate
 description of its function.

 Props @sirbrillig, @sstoqnov

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38651#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list