[wp-trac] [WordPress Trac] #38750: Split wp_signups into wp_user_signups and wp_blog_signups

[WordPress Trac]

#38750: Split wp_signups into wp_user_signups and wp_blog_signups
-------------------------------------------------+-------------------------
 Reporter:  johnjamesjacoby                      |       Owner:
     Type:  feature request                      |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Login and Registration               |  Review
 Severity:  normal                               |     Version:  3.0
 Keywords:  2nd-opinion needs-screenshots        |  Resolution:
  needs-unit-tests needs-patch                   |     Focuses:  multisite
-------------------------------------------------+-------------------------

Comment (by johnjamesjacoby):

 An alternative would be to ditch `wp_signups` all together, and add
 `status` and `creator` columns to `wp_blogs`.

 Then, when a user is activated, the process would be:

 * Check `wp_users::user_activation_key`
 * Switch their `user_status` from `pending` to `active`
 * Check for `wp_blogs::status` in `pending` with a matching `creator_id`
 to the `wp_users::user_id`
 * Switch `wp_blogs::status` from `pending` to `active`

 This has the net positives of:

 * Eliminating an unloved API
 * Removing a weird database table
 * Unifying sign-ups across single & multi site installation types
 * Giving plugins a reliable API & schema to use going forward

 ...at the cost of...

 * Needing to refactor the existing WPMU specific code
 * Deprecating a truckload of code
 * Updating various interfaces to include "Pending" users, and the
 associated links to handle manual activation, etc...
 * Developer awareness that `wp_signups` is going away
 * Probably a several step, several release cycle development plan

 See also #34316.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38750#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform