[wp-trac] [WordPress Trac] #38476: Twenty Seventeen: Focused controls may be hidden by the top menu.

[WordPress Trac]

#38476: Twenty Seventeen: Focused controls may be hidden by the top menu.
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:
     Type:  defect (bug)                         |  davidakennedy
 Priority:  normal                               |      Status:  reopened
Component:  Bundled Theme                        |   Milestone:  4.7
 Severity:  normal                               |     Version:
 Keywords:  has-screenshots has-patch needs-     |  Resolution:
  testing dev-feedback                           |     Focuses:  ui,
                                                 |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Sorry for reopening but I'd like to hear more feedback on this and have
 some more testing. I've tested ;) but more eyes would be appreciated. I'd
 recommend to test with Firefox (because Chrome tends to scroll to the
 middle of the page).

 I think the `600ms` interval should be way shorter, maybe `0`. The thing
 is, when you keep the tab key pressed, and thus focus will move very
 quickly through controls, the interval is too long and will cause the page
 to "jump". That's because the browser has already moved focus on the
 following controls but the JS scrolling is still running.

 The goal here shouldn't be to have a nice "smooth scrolling" effect,
 instead the fix should try to emulate as much as possible the native
 browsers behaviour.

 Also, worth considering this works just for links and ignores form fields,
 buttons, or other focusable controls that may be hidden under the top nav.
 To test, just put the search widget in your sidebar. Wondering if the fix
 should work for ''any'' focusable control.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38476#comment:19>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform