[wp-trac] [WordPress Trac] #38651: Customizer edit icons may be partially off-screen in Device Preview mode
WordPress Trac
noreply at wordpress.org
Thu Nov 10 08:07:03 UTC 2016
#38651: Customizer edit icons may be partially off-screen in Device Preview mode
-------------------------------------------------+-------------------------
Reporter: afercia | Owner: sirbrillig
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.7
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: has-screenshots has-patch reporter- | Focuses:
feedback 2nd-opinion |
-------------------------------------------------+-------------------------
Comment (by sstoqnov):
Well guys, it seems that there is not a perfect solution.
I have reviewed the themes structure and in my opinion there are two ways
to fix this issue:
1. We can change the twentyfourteen theme and add a body class
`twentyfourteen`, so we will have additional selector that we can use to
fix issue. I don't like it, because we will add a theme fix in customizer
styles. But it's good, because we will add only one row in twentyfourteen
theme (`$classes[] = 'twentyfourteen' `)
2. The other solution is to fix this at theme styles, which will require
changing `twentyfourteen` and `twentyseventeen` styles. Attached a diff
for this solution.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38651#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list