[wp-trac] [WordPress Trac] #38672: Custom CSS should work with existing Jetpack custom CSS
WordPress Trac
noreply at wordpress.org
Wed Nov 9 18:19:34 UTC 2016
#38672: Custom CSS should work with existing Jetpack custom CSS
-----------------------------+------------------------------
Reporter: helen | Owner: georgestephanis
Type: defect (bug) | Status: reviewing
Priority: highest omg bbq | Milestone: 4.7
Component: Customize | Version:
Severity: blocker | Resolution:
Keywords: has-patch | Focuses:
-----------------------------+------------------------------
Comment (by georgestephanis):
Tentative needs (discussing in #core-customize)
* Abstract out `wp_get_custom_css_post` -- fetching the CPT Post and
returning it from existing usages in
`WP_Customize_Custom_CSS_Setting::update()` and in `wp_get_custom_css()`
* Filter in `WP_Customize_Custom_CSS_Setting::update()` to allow
modification of cpt before it's saved in the db.
This would be very useful to allow saving of preprocessor stuff -- less,
scss -- in `post_content_formatted`, and the post-processed stuff in
`post_content` of the core CPT -- which should ensure that if they turn
off Jetpack, they can still edit the generated css.
If `final` was removed, I could child class
`WP_Customize_Custom_CSS_Setting` -- but then it's basically treating it
as a pluggable function, and multiple plugins could fight over which child
class 'wins' -- and then everyone loses. A filter is more stable for
extensibility imo
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38672#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list