[wp-trac] [WordPress Trac] #38700: REST API: Cannot send an empty or no-op comment update

[WordPress Trac]

#38700: REST API: Cannot send an empty or no-op comment update
------------------------------------------------+--------------------------
 Reporter:  jnylen0                             |       Owner:  rmccue
     Type:  defect (bug)                        |      Status:  assigned
 Priority:  normal                              |   Milestone:  Future
Component:  REST API                            |  Release
 Severity:  normal                              |     Version:  trunk
 Keywords:  has-patch has-unit-tests 4.8-early  |  Resolution:
                                                |     Focuses:
------------------------------------------------+--------------------------

Comment (by jnylen0):

 [attachment:38700.5.diff] handles the possible `false` return value from
 `$wpdb->update`.  Note, this is an additional bugfix: currently we are not
 catching this error in trunk.

 It does seem wise to me to avoid major changes to `wp_comment_update` this
 late in the cycle.  For example, [attachment:38700.wp-error.diff] contains
 a behavior change: the function will bail out earlier than before if the
 database update fails.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38700#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform