[wp-trac] [WordPress Trac] #38673: Handle languages as 'DISALLOW_FILE_MODS' is activated

[WordPress Trac]

#38673: Handle languages as 'DISALLOW_FILE_MODS' is activated
------------------------------------+------------------------------
 Reporter:  MaximeCulea             |       Owner:
     Type:  enhancement             |      Status:  new
 Priority:  normal                  |   Milestone:  Awaiting Review
Component:  I18N                    |     Version:  trunk
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+------------------------------
Changes (by MaximeCulea):

 * keywords:  needs-patch => has-patch dev-feedback


Comment:

 Please find the according patch in attached files : 38673-patch.diff.

 By applying this patch, people can now filter the `DISALLOW_FILE_MODS`
 constant. So, to conclude with the way to allow people adding languages,
 or whatever, while `DISALLOW_FILE_MODS` is activated, it is only needed to
 filter `wp_disallow_file_mods` like this :
 {{{add_action( 'disallow_file_mods_download_language_pack',
 '__return_false' );}}}

 I am now why wondering about doing this @swissspidy .. because we are like
 trepassing '''security''' behaviour of php constants which could not be
 redefined, isn't it ?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38673#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform