[wp-trac] [WordPress Trac] #38387: Twenty Seventeen: Keyboard navigation on Safari 10

[WordPress Trac]

#38387: Twenty Seventeen: Keyboard navigation on Safari 10
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:
     Type:  defect (bug)                         |  davidakennedy
 Priority:  normal                               |      Status:  assigned
Component:  Bundled Theme                        |   Milestone:  4.7
 Severity:  normal                               |     Version:
 Keywords:  has-patch needs-testing dev-         |  Resolution:
  feedback                                       |     Focuses:
                                                 |  accessibility
-------------------------------------------------+-------------------------
Changes (by davidakennedy):

 * keywords:  has-patch needs-testing => has-patch needs-testing dev-
               feedback


Comment:

 We talked about this today in the bug scrub, and after some
 experimentation, I think I have a good solution. In
 [attachment:38387.2.patch], I add the `href`, but keep `xlink:href` too.
 In testing, many browsers have not implemented just `href` including
 Safari 10, IE 11 and more. But according to the spec, both can be there.
 See:

 https://www.w3.org/TR/SVG2/linking.html#XLinkRefAttrs

 I didn't alter the declarations at the top of the SVG file, again for
 maximum compatibility. Those are these:


 {{{
 version="1.1" xmlns="http://www.w3.org/2000/svg"
 xmlns:xlink="http://www.w3.org/1999/xlink"
 }}}

 This worked well in all the target browsers, plus some older ones with SVG
 support.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38387#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform