[wp-trac] [WordPress Trac] #38659: Twenty Seventeen: Fixes in SVG markup

[WordPress Trac]

#38659: Twenty Seventeen: Fixes in SVG markup
-------------------------------------------------+-------------------------
 Reporter:  sami.keijonen                        |       Owner:
     Type:  enhancement                          |  davidakennedy
 Priority:  normal                               |      Status:  assigned
Component:  Bundled Theme                        |   Milestone:  4.7
 Severity:  normal                               |     Version:  trunk
 Keywords:  has-screenshots has-patch needs-     |  Resolution:
  refresh                                        |     Focuses:
                                                 |  accessibility
-------------------------------------------------+-------------------------

Comment (by sami.keijonen):

 In [https://core.trac.wordpress.org/attachment/ticket/38659/38659.1.patch
 38659.1.patch] there is a little modified SVG markup as we talked. I kind
 of run out of time but can test more tomorrow.

 Tested quickly with these.


 {{{
 <?php echo twentyseventeen_get_svg( array( 'icon' => 'arrow-right',
 'title' => __( 'This is title', 'twentyseventeen' ) ) ); // Title gets
 output. ?>

 <?php echo twentyseventeen_get_svg( array( 'icon' => 'arrow-right', 'desc'
 => __( 'This is desc', 'twentyseventeen' ) ) ); // Nothing gets output. ?>

 <?php echo twentyseventeen_get_svg( array( 'icon' => 'arrow-right',
 'title' => __( 'This is title', 'twentyseventeen' ), 'desc' => __( 'This
 is longer desc', 'twentyseventeen' ) ) ); // Title and desc gets output.
 ?>
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38659#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform