[wp-trac] [WordPress Trac] #38678: Video Headers: Improve Basic Accessibility

WordPress Trac noreply at wordpress.org
Sun Nov 6 23:55:10 UTC 2016


#38678: Video Headers: Improve Basic Accessibility
---------------------------+----------------------------
 Reporter:  davidakennedy  |       Owner:
     Type:  defect (bug)   |      Status:  new
 Priority:  normal         |   Milestone:  4.7
Component:  Themes         |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  has-patch      |     Focuses:  accessibility
---------------------------+----------------------------

Comment (by bradyvercher):

 [attachment:38678.1.diff] builds on the previous patches and refactors
 things a bit. It:

 * Moves the button creation and logic into the main custom handler class
 * Adds a `setVideo()` method for handlers to add the video node to the
 container to DRY things up
 * Adds `play()`, `pause()`, and `paused()` methods to the handlers
 * Triggers play and pause events on the container from the handlers so the
 button text can be updated based on the video state
 * Toggles a class on the button based on the video state so themes can
 show an appropriate icon
 * Makes the button text translatable

 This should fix #38654 as well.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38678#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list