[wp-trac] [WordPress Trac] #38476: Twenty Seventeen: Focused controls may be hidden by the top menu.

WordPress Trac noreply at wordpress.org
Sat Nov 5 19:54:46 UTC 2016


#38476: Twenty Seventeen: Focused controls may be hidden by the top menu.
-------------------------------------------------+-------------------------
 Reporter:  afercia                              |       Owner:
     Type:  defect (bug)                         |  davidakennedy
 Priority:  normal                               |      Status:  assigned
Component:  Bundled Theme                        |   Milestone:  4.7
 Severity:  normal                               |     Version:
 Keywords:  has-screenshots has-patch needs-     |  Resolution:
  testing dev-feedback needs-refresh             |     Focuses:  ui,
                                                 |  accessibility
-------------------------------------------------+-------------------------
Changes (by afercia):

 * keywords:  has-screenshots has-patch needs-testing dev-feedback => has-
     screenshots has-patch needs-testing dev-feedback needs-refresh


Comment:

 Tested a bit and the current patch works only if the navigation has the
 `site-navigation-fixed` CSS class on DOM ready, which is true only when
 the page is already scrolled and then refreshed.
 The check for fixed nav should happen on every `focus` event so it should
 moved inside the anonymous function. Also, not sure there's the need for
 `e.preventDefault();`.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38476#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list