[wp-trac] [WordPress Trac] #38645: Improve roles reinit when switching between sites

[WordPress Trac]

#38645: Improve roles reinit when switching between sites
-------------------------------------------------+-------------------------
 Reporter:  johnjamesjacoby                      |       Owner:
     Type:  defect (bug)                         |      Status:  new
 Priority:  normal                               |   Milestone:  Awaiting
Component:  Role/Capability                      |  Review
 Severity:  normal                               |     Version:  trunk
 Keywords:  has-patch needs-testing early 2nd-   |  Resolution:
  opinion                                        |     Focuses:  multisite
-------------------------------------------------+-------------------------
Changes (by flixos90):

 * keywords:  has-patch needs-testing early => has-patch needs-testing early
     2nd-opinion


Comment:

 Replying to [comment:9 johnjamesjacoby]:
 > Then we need to rename `WP_User::for_blog()`. The inconsistency would be
 worse DUX than the mild inaccuracy, because anyone who does go digging
 will think for_blog and for_site do different things.

 We have a lot of such inconsistencies in multisite naming already (for
 example it's confusing that `get_site_option()` and `get_network_option()`
 both deal with network options). I think we should approach it in the way
 that we iteratively clean up the previous naming conventions in old code,
 thus not add any of these incorrect naming conventions in new code.
 Developers who work with Multisite are expected to be aware of these
 inconsistencies, and having clear doc blocks for functions/methods like
 these will help prevent confusion. Tickets like #36717 had that specific
 purpose.

 Regarding this very issue, I opened a ticket to adjust that in #38681.

 I think we slightly disagree here in the approach, so a third opinion
 would be much appreciated. I think this topic would make a good discussion
 for multisite office hours @jeremyfelt?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38645#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform