[wp-trac] [WordPress Trac] #32577: Customizer QUnit tests not cleaning up

WordPress Trac noreply at wordpress.org
Sat Nov 5 04:16:40 UTC 2016


#32577: Customizer QUnit tests not cleaning up
--------------------------+-----------------------------
 Reporter:  iseulde       |       Owner:  dlh
     Type:  defect (bug)  |      Status:  reviewing
 Priority:  normal        |   Milestone:  Future Release
Component:  Customize     |     Version:  4.3
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:  javascript
--------------------------+-----------------------------
Changes (by dlh):

 * keywords:  needs-patch => has-patch


Comment:

 [attachment:32577.3.patch] implements the CSS approach from
 [ticket:32577#comment:10], which seems pretty straightforward and works as
 expected in my testing.

 The patch also attempts to supplement the CSS with a different method of
 cleaning up the DOM: Rather than attempting to pick off individual
 elements -- some of which appear to be created separately from of the
 tests themselves, if I followed correctly? -- it removes all of them at
 the end of the test suite, with one exception.

 Of course, this approach still doesn't meet the goal of removing fixtures
 after each module or test. Plus, once you get to `QUnit.done()`, using `$(
 '#customize-theme-controls' ).remove()` would accomplish the same thing.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/32577#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list