[wp-trac] [WordPress Trac] #38544: Header Visuals > Header Video Vimeo url don't work

WordPress Trac noreply at wordpress.org
Fri Nov 4 22:44:36 UTC 2016


#38544: Header Visuals >  Header Video Vimeo url don't work
--------------------------+-----------------------------
 Reporter:  llemurya      |       Owner:  joemcgill
     Type:  defect (bug)  |      Status:  reopened
 Priority:  normal        |   Milestone:  4.7
Component:  Customize     |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  ui, javascript
--------------------------+-----------------------------

Comment (by westonruter):

 Also, in `\WP_Customize_Manager::_validate_external_header_video()` it’s
 using `esc_url()` with a (default) `display` context. It probably won’t
 impact the validation logic as it stands right now, but `esc_url()` will
 inject HTML entities into the returned string, so that could cause
 unexpected behavior. In short, I think this should be changed to use
 `esc_url_raw()` instead.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38544#comment:10>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list