[wp-trac] [WordPress Trac] #38672: Custom CSS should work with existing Jetpack custom CSS
WordPress Trac
noreply at wordpress.org
Fri Nov 4 22:27:17 UTC 2016
#38672: Custom CSS should work with existing Jetpack custom CSS
-----------------------------+------------------
Reporter: helen | Owner:
Type: defect (bug) | Status: new
Priority: highest omg bbq | Milestone: 4.7
Component: Customize | Version:
Severity: blocker | Resolution:
Keywords: | Focuses:
-----------------------------+------------------
Comment (by westonruter):
Replying to [comment:1 beaulebens]:
> On the Jetpack side, we're more than happy to work out a plan for making
things compatible, and honestly are a bit surprised that this feature
happened completely independently, with no input or interaction. Jetpack
has had Custom CSS [https://jetpack.com/2012/08/23/jetpack-1-7-custom-css/
since 2012].
For what it's worth, I did ping the Jetpack team about the developments of
the Additional CSS feature being worked on in core:
https://github.com/Automattic/jetpack/issues/1621#issuecomment-247155624
Also, the Custom CSS feature in Jetpack is not the only plugin that
provides the feature, so I don't think that it's necessarily something
that needed to be dependent on collaboration with specifically Jetpack,
though earlier collaboration would certainly have been ideal. Naturally
the two should not be incompatible as the feature in Jetpack may have the
most marketshare.
> Can you (or someone) point me to any decision process around why the
core editor is theme-specific vs global perhaps? That seems like one of
the most fundamental actual differences right now.
Yes. The decision there was centered around the fact that themes normally
have different styles and so the styles that are added to customize the
appearance of one theme may not apply correctly when applying to another
theme. It's the same thought process behind the decision to make Custom
Logo a theme mod and not an option. Consider a theme having a different
color scheme or even elements which have different class names in the
markup. In #38549 I've suggested that a user be able to import CSS from
another theme via a dropdown to opt-in instead of having it copy by
default.
As you noted, the custom CSS feature currently merged in core is pretty
stripped-down in terms of its UI and functionality. If we can make sure
the underlying infrastructure is aligned, I love your idea to let Jetpack
then extend what is in core and provide a large user base to test the
improvements which could then be merged into core in future releases.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38672#comment:7>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list