[wp-trac] [WordPress Trac] #38629: REST API: Allowed public or private WP_Query vars are lost in `prepare_items_query()`

[WordPress Trac]

#38629: REST API: Allowed public or private WP_Query vars are lost in
`prepare_items_query()`
--------------------------+-----------------------
 Reporter:  rachelbaker   |       Owner:  rmccue
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.7
Component:  REST API      |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  has-patch     |     Focuses:
--------------------------+-----------------------

Comment (by joehoyle):

 I think the filter is good, which we should add to all controllers. I'm
 still -1 on moving the `query_var` to the registration. Mainly because I
 think it's a level of abstraction that isn't needed, and carry this
 pattern to cross function boundaries (get_collection_params to get_items)
 makes this unpleasant peace of code even more embedded across the
 controller. I think it was simpler beforehand, and I don't think it's
 worth the up side flexibility to add this.

 I'm deferring to @rmccue for the direction there though - above is my
 opinion but I have no issue if I'm outvoted on this!

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38629#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform