[wp-trac] [WordPress Trac] #38660: Customizer: Edit shortcuts buttons: consider to don't use flexbox

WordPress Trac noreply at wordpress.org
Fri Nov 4 09:40:32 UTC 2016


#38660: Customizer: Edit shortcuts buttons: consider to don't use flexbox
--------------------------+-----------------------------
 Reporter:  afercia       |      Owner:
     Type:  defect (bug)  |     Status:  new
 Priority:  normal        |  Milestone:  4.7
Component:  Customize     |    Version:  trunk
 Severity:  normal        |   Keywords:  has-screenshots
  Focuses:                |
--------------------------+-----------------------------
 Testing the new edit shortcut buttons in IE 11, the positioning of the
 icons is a bit off (red background is just for testing purposes):

 [[Image(https://cldup.com/PDpHWb6fo5.jpg)]]

 I'd consider to don't use flexbox at all, and use a more traditional
 layout model instead.
 - theoretically, the Customizer should still support IE 9+
 - have a look at the [http://caniuse.com/#search=flexbox known flexbox
 bugs on caniuse.com]
 - [https://bugzilla.mozilla.org/show_bug.cgi?id=984869#c2 Firefox does not
 support flexbox in button elements], as far as I understand this is going
 to be solved soon

 Is there really the need to use flexbox? browsers already horizontally
 center anything inside buttons.
 About vertical centering, the buttons and icons have fixed width so it's
 just a matter of ensuring the buttons have always `box-sizing: border-box`
 and then use `padding: 3px`

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38660>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list