[wp-trac] [WordPress Trac] #38199: Update npm dependencies for 4.7

WordPress Trac noreply at wordpress.org
Fri Nov 4 07:32:24 UTC 2016


#38199: Update npm dependencies for 4.7
------------------------------+-----------------------
 Reporter:  jorbin            |       Owner:  jorbin
     Type:  task (blessed)    |      Status:  assigned
 Priority:  normal            |   Milestone:  4.7
Component:  Build/Test Tools  |     Version:
 Severity:  normal            |  Resolution:
 Keywords:                    |     Focuses:
------------------------------+-----------------------

Comment (by netweb):

 Patch [attachment:38199.diff] contains updates to `grunt`, `grunt-legacy-
 util`, and `grunt-includes`

 * `grunt` 0.4.5 -> 1.0.1
 [https://github.com/gruntjs/grunt/compare/v0.4.5...v1.0.1 changelog]
 *  `grunt-legacy-util` 0.2.0 -> 1.0.0 [https://github.com/gruntjs/grunt-
 legacy-util/compare/v0.2.0...v1.0.0 changelog`
 * `grunt-includes` 0.5.4 -> 1.0.0 [https://github.com/vanetix/grunt-
 includes/compare/864b5964469d45584f0adeaa797266e24c547654...master
 changelog]

 Research following commit r39118 and subsequent revert r39119 did *not*
 break the build server due to a NodeJS incompatibility:
 *  `grunt-includes` has `peerDependencies ` of `"grunt": ">=1.0.0"`
 ([https://github.com/vanetix/grunt-includes/blob/master/package.json#L26
 src])
 * `grunt-includes` has a minimum NodeJS version of `"node": ">= 0.8.0"`
 ([https://github.com/vanetix/grunt-includes/blob/master/package.json#L33
 src])
 * `grunt-includes` incorporates Travis CI testing for
 [https://github.com/vanetix/grunt-includes/blob/master/.travis.yml#L7
 NodeJS 0.10.x], with current Travis CI [https://travis-ci.org/vanetix
 /grunt-includes tests passing]

 ----

 I've tested each of the following tasks individually and each worked as
 expected:
 * `grunt`, `grunt build`
 * `grunt watch` (Tested watching PHP, CSS, SCSS, JS files)
 * `grunt travis:js`, `grunt travis:phpunit`,
 * `grunt qunit`, `grunt qunit:compiled`
 * `grunt precommit`, `grunt prerelease`
 * `grunt includes`,`grunt includes:emoji`, `grunt includes:embed`

 What's the worst that could happen, Friday commit right here in
 [attachment:38199.diff] #yolo

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38199#comment:15>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list