[wp-trac] [WordPress Trac] #37513: Admin bar sub menu items dashicon and screen readers

[WordPress Trac]

#37513: Admin bar sub menu items dashicon and screen readers
-----------------------------------------+--------------------------------
 Reporter:  afercia                      |       Owner:  afercia
     Type:  defect (bug)                 |      Status:  reopened
 Priority:  normal                       |   Milestone:  4.7
Component:  Toolbar                      |     Version:
 Severity:  normal                       |  Resolution:
 Keywords:  has-screenshots needs-patch  |     Focuses:  ui, accessibility
-----------------------------------------+--------------------------------

Comment (by keraweb):

 @afercia Ah I understand that.

 I know my plugin is also not compatible with this patch but that is easily
 fixed before the release of 4.7 (I already fixed it in local dev).

 But I think more plugins use the `top-secondary`. That's the reason I
 think it's better to align them correctly in this phase already.

 The reason to check the correct tree is because the method needs to know
 what the root item is in order to know which icon to show and on what
 location. Not sure this can be fixed without checking the tree. If the
 current node is a level 4 node it's parent would be a level 3 node and
 this won't validate against `root-default` or `top-secondary`.

 Also, the `is_tree()` function can even be used for more purposes since it
 checks all parents, not just the root.

 '''Option 1:'''
 One solution without any new methods would be to do the check within the
 code instead of in a separate method. Not sure on how to do this without
 large code blocks...

 '''Option 2:'''
 Although I can patch a fix easily for my plugin so the release won't
 really hurt it, I personally think it should work 100% for a major version
 release right?
 Even though it's a minor accessibility improvement it's quite a difference
 for the UI and gives a weird view on all parent items that are nested
 under `top-secondary`.

 And thanks for the hint! I'll look into that :).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37513#comment:27>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform