[wp-trac] [WordPress Trac] #37513: Admin bar sub menu items dashicon and screen readers

WordPress Trac noreply at wordpress.org
Thu Nov 3 16:03:31 UTC 2016


#37513: Admin bar sub menu items dashicon and screen readers
---------------------------------------+--------------------------------
 Reporter:  afercia                    |       Owner:  afercia
     Type:  defect (bug)               |      Status:  closed
 Priority:  normal                     |   Milestone:  4.7
Component:  Toolbar                    |     Version:
 Severity:  normal                     |  Resolution:  fixed
 Keywords:  has-screenshots has-patch  |     Focuses:  ui, accessibility
---------------------------------------+--------------------------------

Comment (by keraweb):

 Just checked the actual changes and the problem is with this line:

 {{{#!php
 <?php
 $is_top_secondary_item = 'top-secondary' === $node->parent;
 }}}

 This only check the current items parent, not it's tree.

 Maybe add a method to get the current item tree. Could be handy in more
 cases.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/37513#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list