[wp-trac] [WordPress Trac] #37032: Guard against infinite reload when setting change causes premature selective refresh
WordPress Trac
noreply at wordpress.org
Thu Nov 3 05:06:20 UTC 2016
#37032: Guard against infinite reload when setting change causes premature
selective refresh
-------------------------------------+--------------------------
Reporter: westonruter | Owner: westonruter
Type: defect (bug) | Status: closed
Priority: normal | Milestone: 4.7
Component: Customize | Version: 4.5
Severity: normal | Resolution: fixed
Keywords: has-patch needs-testing | Focuses:
-------------------------------------+--------------------------
Changes (by westonruter):
* status: accepted => closed
* resolution: => fixed
Comment:
In [changeset:"39112"]:
{{{
#!CommitTicketReference repository="" revision="39112"
Customize: Prevent syncing unmodified settings from controls into preview
to guard against triggering an infinite reload due to selective refresh
fallback behavior.
If a value is sanitized in PHP and differs from the JS value in the pane,
a `change` event for the setting is triggered upon refresh. This should be
avoided since the value just came from the server as being sanitized. This
also fixes periodic issue where selective refresh happens immediately
after a full refresh.
Fixes #37032.
}}}
--
Ticket URL: <https://core.trac.wordpress.org/ticket/37032#comment:11>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list