[wp-trac] [WordPress Trac] #38629: REST API: Allowed public or private WP_Query vars are lost in `prepare_items_query()`

WordPress Trac noreply at wordpress.org
Wed Nov 2 22:12:31 UTC 2016


#38629: REST API: Allowed public or private WP_Query vars are lost in
`prepare_items_query()`
--------------------------+-----------------------
 Reporter:  rachelbaker   |       Owner:  rmccue
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.7
Component:  REST API      |     Version:  trunk
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:
--------------------------+-----------------------

Comment (by jnylen0):

 This looks nice and clean overall.  A comment and a question:

 - I'm not sure about "Enables adding '''or removing''' collection
 parameters from the endpoint."  Maybe it shouldn't be strictly impossible,
 but we decided over at #38339 that we should discourage disabling the
 built-in features.
 - Do all of the affected arguments have working test cases, including
 anything that touches `WP_REST_Attachments_Controller`?  I know `'slug' =>
 'post_name__in'` is fine and `'status' => 'post_status'` will be fine once
 #38420 is resolved.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38629#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list