[wp-trac] [WordPress Trac] #38630: Discourage usage of legacy properties in WP_Site

[WordPress Trac]

#38630: Discourage usage of legacy properties in WP_Site
--------------------------------+-------------------------------
 Reporter:  flixos90            |      Owner:
     Type:  enhancement         |     Status:  new
 Priority:  normal              |  Milestone:  Future Release
Component:  Networks and Sites  |    Version:
 Severity:  normal              |   Keywords:  needs-patch early
  Focuses:  multisite           |
--------------------------------+-------------------------------
 Working on #38597, it was figured out that the best solution for handling
 problems with IDE handling of `WP_Network`s magic ID property is to rename
 the actual properties to reflect our current naming conventions. This
 enhancement will encourage to use the new conventions while still
 supporting the old ones for legacy code.

 Let's do the same for `WP_Site`:
 * `$blog_id` (string) is replaced with `$id` (int)
 * `$site_id` (string) is replaced with `$network_id` (int)
 * both legacy names will continue to work through magic methods

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38630>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform