[wp-trac] [WordPress Trac] #38532: Customizer: Edit shortcuts buttons: clicking does not work in Firefox
WordPress Trac
noreply at wordpress.org
Wed Nov 2 20:48:04 UTC 2016
#38532: Customizer: Edit shortcuts buttons: clicking does not work in Firefox
---------------------------------------+-------------------------
Reporter: sirbrillig | Owner: sirbrillig
Type: defect (bug) | Status: assigned
Priority: normal | Milestone: 4.7
Component: Customize | Version: trunk
Severity: normal | Resolution:
Keywords: needs-testing needs-patch | Focuses:
---------------------------------------+-------------------------
Comment (by celloexpressions):
If possible it would be good for themes to be able to use `.customize-
partial-edit-shortcut` for their styling adjustments, as that's already a
very long class name. We'll need to update Twenty Seventeen's usage of
that in the patch here if we do change it. `.customize-partial-edit-
shortcut button` feels okay and equivalent to `.customize-partial-edit-
shortcut:before`, but from a themer's perspective needing to remember
another very long class name for the inner button should be avoided.
Before commit, we also need to re-test with all eight bundled themes as
well as a sampling of themes on .org to consider adding `!important`s to
the core styles accordingly, based on the increased likelihood of
inheriting theme styles on `button`. I'd like to see it work out of the
box with a few changes as possible required by bundled themes, although
the Twenty Seventeen ones will need to stay. Twenty Seventeen also has
instances of this in `inc/color-patterns.php` that'll need updating,
reference the initial commit on #27403.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38532#comment:12>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list