[wp-trac] [WordPress Trac] #38550: Remove jQuery dependency from wp-custom-header.js
WordPress Trac
noreply at wordpress.org
Wed Nov 2 15:48:04 UTC 2016
#38550: Remove jQuery dependency from wp-custom-header.js
--------------------------+-------------------------
Reporter: joemcgill | Owner: joemcgill
Type: defect (bug) | Status: accepted
Priority: normal | Milestone: 4.7
Component: Themes | Version:
Severity: normal | Resolution:
Keywords: has-patch | Focuses: javascript
--------------------------+-------------------------
Changes (by joemcgill):
* keywords: 2nd-opinion has-patch => has-patch
Comment:
Thanks @adamsilverstein, I was assuming the browser check wasn't necessary
on the `wp-custom-header.js` side since we're bailing early if there is no
support for `addEventListener`, but didn't think to do the same on the
theme side. [attachment:38550.3.diff] looks good to me, assuming the
overall strategy here makes sense.
--
Ticket URL: <https://core.trac.wordpress.org/ticket/38550#comment:8>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list