[wp-trac] [WordPress Trac] #38390: Twenty Seventeen: Playlists don't render on blog/archive pages

WordPress Trac noreply at wordpress.org
Wed Nov 2 04:09:52 UTC 2016


#38390: Twenty Seventeen: Playlists don't render on blog/archive pages
---------------------------+------------------------
 Reporter:  melchoyce      |       Owner:  joemcgill
     Type:  defect (bug)   |      Status:  accepted
 Priority:  normal         |   Milestone:  4.7
Component:  Bundled Theme  |     Version:
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:
---------------------------+------------------------

Comment (by joemcgill):

 As @laurelfulford
 [https://github.com/WordPress/twentyseventeen/issues/429#issuecomment-254651487
 mentioned on GitHub], the issue here is a result of the way the `content-
 audio.php` and `content-video.php` template partials in TwentySeventeen
 attempt to highlight media found in post content by using
 `get_media_embedded_in_content()` to attempt to extract videos from the
 content and display their HTML differently.

 However, the HTML being generated by the playlist shortcode relies on JS
 to update the video element with the markup needed to display the playlist
 properly. The `get_media_embedded_in_content()` function wasn't designed
 to handle this use case.

 We should probably look into adding some logic to
 `get_media_embedded_in_content()` that accounts for the playlist markup,
 but in the short-term, I would suggest addressing this in the theme by
 adding a check for the presence of the playlist shortcode before trying to
 modify the content that is displayed in `! is_single()` contexts.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38390#comment:9>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list