[wp-trac] [WordPress Trac] #38604: Twenty Seventeen: Skip to content link broken in IE

[WordPress Trac]

#38604: Twenty Seventeen: Skip to content link broken in IE
---------------------------+----------------------------------------
 Reporter:  sami.keijonen  |       Owner:  davidakennedy
     Type:  defect (bug)   |      Status:  assigned
 Priority:  normal         |   Milestone:  4.7
Component:  Bundled Theme  |     Version:  trunk
 Severity:  normal         |  Resolution:
 Keywords:  needs-patch    |     Focuses:  accessibility, javascript
---------------------------+----------------------------------------
Changes (by afercia):

 * status:  new => assigned
 * focuses:  accessibility => accessibility, javascript
 * component:  Themes => Bundled Theme
 * owner:   => davidakennedy
 * milestone:  Awaiting Review => 4.7
 * keywords:   => needs-patch


Comment:

 Replying to [ticket:38604 sami.keijonen]:
 > I'm not sure why we even try to check different browsers. Why not just
 always use `tabindex=-1` on `#content` when clickin skip to content?

 Because not all browsers need this fix. The script should be updated in
 order to account for browsers progress:
 - Firefox is the only major browser that always honoured a correct tab
 order when focusing an "in-page" anchor
 - Chrome doesn't need this fix any longer since version 50
 - I guess this applies to Opera (webkit) too, needs testing
 - still needed for Opera 12 (Presto) but probably support for old Opera
 can be dropped
 - Safari doesn't need this fix since version 10, still needed for version
 9
 - IE 11 returns a user agent string without `msie` for me, I guess the
 script should check for `trident` too
 - Edge doesn't need any fix

--
Ticket URL: <https://core.trac.wordpress.org/ticket/38604#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform