[wp-trac] [WordPress Trac] #36906: Comment caches should be persistent

WordPress Trac noreply at wordpress.org
Mon May 30 13:57:15 UTC 2016


#36906: Comment caches should be persistent
------------------------------------------+-----------------------------
 Reporter:  boonebgorges                  |       Owner:
     Type:  defect (bug)                  |      Status:  new
 Priority:  normal                        |   Milestone:  Future Release
Component:  Comments                      |     Version:  2.2
 Severity:  normal                        |  Resolution:
 Keywords:  needs-patch needs-unit-tests  |     Focuses:  performance
------------------------------------------+-----------------------------
Changes (by boonebgorges):

 * keywords:   => needs-patch needs-unit-tests


Comment:

 > Is there any chance this is this might be in 4.6?

 It's possible, but someone (maybe you?!) will have to take the initiative
 to do the research, etc.

 I'd suggest starting with a look through the logs to see when the
 `'comment'` was made non-persistent. I assume that this was a change made
 to fix certain invalidation problems. The conversations around the change
 probably contain some useful warnings.

 > Are there any unit test that can help?

 We have a lot of comment-related unit tests. `$ phpunit --group comment`
 But these test mostly only cover previous bugs, so it's likely that there
 are gaps. A good strategy is to search the codebase for all the places
 where a comment can be updated/deleted/created, and then to cross-
 reference against the existing tests to see whether there are tests
 covering the necessary invalidation.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36906#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list