[wp-trac] [WordPress Trac] #36345: We shouldn't use "full" as image size name in wp_calculate_image_srcset()

[WordPress Trac]

#36345: We shouldn't use "full" as image size name in wp_calculate_image_srcset()
----------------------------+------------------------
 Reporter:  jaspermdegroot  |       Owner:  joemcgill
     Type:  defect (bug)    |      Status:  accepted
 Priority:  normal          |   Milestone:  4.6
Component:  Media           |     Version:  4.4
 Severity:  normal          |  Resolution:
 Keywords:  has-patch       |     Focuses:
----------------------------+------------------------
Changes (by joemcgill):

 * milestone:  Future Release => 4.6


Comment:

 Replying to [comment:4 azaozz]:
 > Perhaps we should "reserve" `full` and even `original` as size names
 that may be used by core, similarly to medium-large.

 I like the idea of reserving both the `original` and `full` size names. In
 the future, I could even see a use case for regenerating a `full` size
 image from the `original` that is the same dimensions if someone uploads a
 file that isn't optimized for the web. This is also another good reason
 for not automatically adding the original file to the `$image_sizes` array
 using `full` as the key name.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36345#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform