[wp-trac] [WordPress Trac] #18877: DRY up rewrite rule matching

WordPress Trac noreply at wordpress.org
Thu May 26 19:54:55 UTC 2016


#18877: DRY up rewrite rule matching
--------------------------------------+--------------------------
 Reporter:  scribu                    |       Owner:
     Type:  enhancement               |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.6
Component:  Rewrite Rules             |     Version:
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  performance
--------------------------------------+--------------------------
Changes (by ericlewis):

 * milestone:  Future Release => 4.6


Comment:

 In attachment:18877.6.diff,

 * Rename the method `find_match()` to `get_rewrite_rule_for_request()` to
 document itself articulately.
 * The method operates on the rewrite rules of the WP_Rewrite instance,
 rather than passing in an array of rewrite rules.

 Feedback and review welcome. Moving this to the 4.6 milestone, and will
 commit soon if there no objections come up.

 cc @rmccue

--
Ticket URL: <https://core.trac.wordpress.org/ticket/18877#comment:22>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list