[wp-trac] [WordPress Trac] #36949: Term exists should use get_terms internally

[WordPress Trac]

#36949: Term exists should use get_terms internally
------------------------------------------+-----------------------------
 Reporter:  spacedmonkey                  |       Owner:
     Type:  enhancement                   |      Status:  new
 Priority:  normal                        |   Milestone:  Future Release
Component:  Taxonomy                      |     Version:  2.3
 Severity:  normal                        |  Resolution:
 Keywords:  needs-unit-tests needs-patch  |     Focuses:  performance
------------------------------------------+-----------------------------
Changes (by boonebgorges):

 * keywords:  has-patch needs-unit-tests => needs-unit-tests needs-patch
 * milestone:  Awaiting Review => Future Release


Comment:

 Thanks. This is a good idea in theory, though I'm not sure how it will pan
 out in practice. First, there are errors in the patch that are causing
 invalid SQL in some cases. Second, relying on the cache in `term_exists()`
 is likely to surface invalidation bugs in places where WordPress uses
 `term_exists()` internally to avoid duplicates. There needs to be a review
 of these places. A good place to start is the dozens of failing tests when
 running `phpunit` with the patch applied :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36949#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform