[wp-trac] [WordPress Trac] #36906: Comment caches should be persistent

[WordPress Trac]

#36906: Comment caches should be persistent
--------------------------+-----------------------------
 Reporter:  boonebgorges  |       Owner:
     Type:  defect (bug)  |      Status:  new
 Priority:  normal        |   Milestone:  Future Release
Component:  Comments      |     Version:  2.2
 Severity:  normal        |  Resolution:
 Keywords:                |     Focuses:  performance
--------------------------+-----------------------------

Comment (by spacedmonkey):

 A quick bit of searching shows that the group isn't being used for
 anything another than storing commet objects and the query caching. Here
 are the references I found.

 https://github.com/WordPress/WordPress/blob/d11bf53a9998cf8ba267c983074c1eb8f3f91dcb
 /wp-includes/comment.php#L1614
 https://github.com/WordPress/WordPress/blob/d11bf53a9998cf8ba267c983074c1eb8f3f91dcb
 /wp-includes/comment.php#L2570
 https://github.com/WordPress/WordPress/blob/d11bf53a9998cf8ba267c983074c1eb8f3f91dcb
 /wp-includes/comment.php#L2582
 https://github.com/WordPress/WordPress/blob/d11bf53a9998cf8ba267c983074c1eb8f3f91dcb
 /wp-includes/comment.php#L2600
 https://github.com/WordPress/WordPress/blob/d11bf53a9998cf8ba267c983074c1eb8f3f91dcb
 /wp-includes/comment.php#L2627
 https://github.com/WordPress/WordPress/blob/d11bf53a9998cf8ba267c983074c1eb8f3f91dcb
 /wp-includes/class-wp-comment.php#L199
 https://github.com/WordPress/WordPress/blob/d11bf53a9998cf8ba267c983074c1eb8f3f91dcb
 /wp-includes/class-wp-comment.php#L208
 https://github.com/WordPress/WordPress/blob/d11bf53a9998cf8ba267c983074c1eb8f3f91dcb
 /wp-includes/class-wp-comment-query.php#L384
 https://github.com/WordPress/WordPress/blob/d11bf53a9998cf8ba267c983074c1eb8f3f91dcb
 /wp-includes/class-wp-comment-query.php#L387
 https://github.com/WordPress/WordPress/blob/d11bf53a9998cf8ba267c983074c1eb8f3f91dcb
 /wp-includes/class-wp-comment-query.php#L391
 https://github.com/WordPress/WordPress/blob/d11bf53a9998cf8ba267c983074c1eb8f3f91dcb
 /wp-includes/class-wp-comment-query.php#L394

 I might call clean_comment_cache on this line.
 https://github.com/WordPress/WordPress/blob/d11bf53a9998cf8ba267c983074c1eb8f3f91dcb
 /wp-includes/comment.php#L1614

 But that is just me being picky. I personally don't see the harm of
 turning it on.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36906#comment:2>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform