[wp-trac] [WordPress Trac] #20263: Backticks in dbDelta cause warning and actually causes a query to alter all columns and indexes to run even if none have changed

[WordPress Trac]

#20263: Backticks in dbDelta cause warning and actually causes a query to alter all
columns and indexes to run even if none have changed
--------------------------------------+------------------------
 Reporter:  Driskell                  |       Owner:  ocean90
     Type:  defect (bug)              |      Status:  reviewing
 Priority:  normal                    |   Milestone:  4.6
Component:  Database                  |     Version:  1.5
 Severity:  normal                    |  Resolution:
 Keywords:  has-unit-tests has-patch  |     Focuses:
--------------------------------------+------------------------
Changes (by ocean90):

 * keywords:  has-unit-tests needs-patch => has-unit-tests has-patch


Comment:

 [attachment:20263.5.diff] normalizes the index definitions so they match
 with the result of `SHOW INDEX FROM` in
 https://core.trac.wordpress.org/browser/trunk/src/wp-
 admin/includes/upgrade.php?rev=37538&marks=2274-2337#L2274.

 The regular expressions are copied from
 [https://backpress.trac.wordpress.org/browser/trunk/includes/class.bp-sql-
 schema-parser.php?marks=118,130#L117 BackPress], slightly changed to have
 named capture groups.

 This patch fixes also #34959, #34873 and #34869. #34874 would be possible
 too.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/20263#comment:21>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform