[wp-trac] [WordPress Trac] #15800: Adding tabs to the "Edit Site"-pages in Network Admin

[WordPress Trac]

#15800: Adding tabs to the "Edit Site"-pages in Network Admin
-------------------------+-------------------------------------------------
 Reporter:               |       Owner:  jeremyfelt
  PuffyThePirateBoy      |      Status:  reopened
     Type:  enhancement  |   Milestone:  4.6
 Priority:  normal       |     Version:  3.1
Component:  Networks     |  Resolution:
  and Sites              |     Focuses:  accessibility, administration,
 Severity:  minor        |  multisite
 Keywords:  needs-patch  |
-------------------------+-------------------------------------------------

Comment (by jeremyfelt):

 [attachment:15800.diff] makes all of these changes. Should have caught the
 documentation stuff.

 Replying to [comment:40 ocean90]:
 > Some feedback about [37466]:
 >
 > * Comments, DocBlock descriptions  and summaries, @param descriptions
 should all end with a period.
 > * We haven't used the `@link` tag to link to tickets yet and I don't
 think it's necessary.
 > * The docs for the first param of `network_edit_site_nav_links` should
 be documented in hash notation style. It's also missing a variable name
 like `$links`. And it should be documented that the URL is relative to
 `network_admin_url()`.

 > * I don't see a need for the output buffer in `network_edit_site_nav()`.

 I think the original intention was caution. I don't think there's any
 problem with removing it.

 > * `$classes` is a hardcoded list, so `$esc_classes` seems superfluous.

 We went back and forth on this a bit. The reason it's there is because an
 earlier patch provided the opportunity to filter those classes. Leaving it
 means that we already have this in place if we start filtering in the
 future. It won't hurt to remove.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/15800#comment:41>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform