[wp-trac] [WordPress Trac] #20263: Backticks in dbDelta cause warning and actually causes a query to alter all columns and indexes to run even if none have changed

WordPress Trac noreply at wordpress.org
Mon May 23 08:50:39 UTC 2016


#20263: Backticks in dbDelta cause warning and actually causes a query to alter all
columns and indexes to run even if none have changed
--------------------------------------------+------------------------
 Reporter:  Driskell                        |       Owner:  ocean90
     Type:  defect (bug)                    |      Status:  reviewing
 Priority:  normal                          |   Milestone:  4.6
Component:  Database                        |     Version:  1.5
 Severity:  normal                          |  Resolution:
 Keywords:  has-patch early has-unit-tests  |     Focuses:
--------------------------------------------+------------------------

Comment (by pento):

 Rather than doing the `ltrim()` magic, I'd be inclined to add the {{{`}}}s
 to the regex. That's the same as how `wpdb::get_table_from_query()`
 behaves, as well as the BackPress example that @ocean90 linked to.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/20263#comment:16>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list