[wp-trac] [WordPress Trac] #36911: Customizer and Theme Installer spinners should have different z-index

WordPress Trac noreply at wordpress.org
Sun May 22 22:27:24 UTC 2016


#36911: Customizer and Theme Installer spinners should have different z-index
-------------------------------------+------------------------------
 Reporter:  afercia                  |       Owner:
     Type:  defect (bug)             |      Status:  new
 Priority:  normal                   |   Milestone:  Awaiting Review
Component:  Customize                |     Version:  4.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  ui
-------------------------------------+------------------------------
Changes (by afercia):

 * keywords:  needs-patch => has-patch needs-testing


Comment:

 In the proposed patch, a minimal approach that removes `z-index` where not
 necessary. The spinner is now a CSS pseudo element natively stacked above
 the full overlay and below the iframe. No need for `z-index`. As far as
 I've tested, should work in all browser except the Theme installer in IE
 because IE doesn't allow iframe transparency when the iframe `src`
 attribute is set to an external domain.

 Places where to check the patch:
 - the "customize container" which opens for example when clicking
 "Customize" on the currently active theme in "Themes" (actually there are
 2 spinners here, the first one initially displayed in the center of the
 page and then a second one in the right frame preview)
 - the standard Customizer right frame preview, for example clicking
 "Customize" on the toolbar from the front end
 - the Theme installer (Themes > Add New > Details & Preview on any theme
 and then browse themes

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36911#comment:3>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list