[wp-trac] [WordPress Trac] #36900: Media grid AttachmentsBrowser arrows navigation and restoreFocus() no longer work

[WordPress Trac]

#36900: Media grid AttachmentsBrowser arrows navigation and restoreFocus() no
longer work
-------------------------------------+------------------------------
 Reporter:  afercia                  |       Owner:  adamsilverstein
     Type:  defect (bug)             |      Status:  assigned
 Priority:  normal                   |   Milestone:  4.5.3
Component:  Media                    |     Version:  4.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-patch needs-testing  |     Focuses:  javascript
-------------------------------------+------------------------------
Changes (by adamsilverstein):

 * keywords:   => has-patch needs-testing
 * milestone:  Awaiting Review => 4.5.3


Comment:

 `listenTo` isn't really required here and seems to be the point of
 failure, switching to the `.on` form (and binding the attachments for
 context) fixes the issue.

 In [attachment:36900.diff]

 * Switch from `listenTo` to `on` when binding listeners to handle keyboard
 navigation and image re-focus in the media grid; the existing listeners
 broke when we upgraded Backbone in [36546].

 Marking for consideration for 4.5.3 since this is a 4.5 regression.
 @afercia can you please test my patch to verify this fixes the issue you
 raised?

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36900#comment:5>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform