[wp-trac] [WordPress Trac] #15800: Adding tabs to the "Edit Site"-pages in Network Admin
WordPress Trac
noreply at wordpress.org
Thu May 19 19:13:19 UTC 2016
#15800: Adding tabs to the "Edit Site"-pages in Network Admin
-------------------------+-------------------------------------------------
Reporter: | Owner:
PuffyThePirateBoy | Status: new
Type: enhancement | Milestone: 4.6
Priority: normal | Version: 3.1
Component: Networks | Resolution:
and Sites | Focuses: accessibility, administration,
Severity: minor | multisite
Keywords: has-patch |
needs-testing |
-------------------------+-------------------------------------------------
Comment (by johnjamesjacoby):
.4.patch changes the following from .3.patch:
* Remove before/after args
* Remove capability changes for each file
* Remove `aria` attributes
* Rename function away from `tabs` and towards` nav`
* Adds attribute escaping to tab classes
* Adds support for default `blog_id` argument
* Switched to `ob_get_clean()` as a precaution, to avoid any other
arbitrary output from getting flushed
Two notes from above:
* Capability checks remain in the `network_edit_site_nav()` function. This
is because the 4 core `sites-*.php` files aren't loaded at the same time
like plugins would be, hence there is no way to decide if they should
appear without pre-registering them elsewhere (likely in another
procedural function) which seems superfluous
* Capability checks in this version of the patch seem silly, because all
of the capabilities are the same, so it takes some imagination to consider
how a plugin will need to have its capability checked
--
Ticket URL: <https://core.trac.wordpress.org/ticket/15800#comment:36>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list