[wp-trac] [WordPress Trac] #34941: Make the main bootstrap process in ms-settings.php testable

[WordPress Trac]

#34941: Make the main bootstrap process in ms-settings.php testable
-------------------------------------------------+-------------------------
 Reporter:  jeremyfelt                           |       Owner:  jeremyfelt
     Type:  enhancement                          |      Status:  accepted
 Priority:  normal                               |   Milestone:  4.6
Component:  Bootstrap/Load                       |     Version:
 Severity:  normal                               |  Resolution:
 Keywords:  has-patch has-unit-tests needs-      |     Focuses:  multisite
  testing commit                                 |
-------------------------------------------------+-------------------------
Changes (by ocean90):

 * keywords:  has-patch has-unit-tests needs-testing => has-patch has-unit-
     tests needs-testing commit


Comment:

 I've tested [attachment:34941.4.diff] on w.org and haven't noticed any
 issues so far.

 Some minor things for the patch itself:
 * "Identify the network" should be "Identifies the network", see
 https://make.wordpress.org/core/handbook/best-practices/inline-
 documentation-standards/php/#documenting-tips
 * The order of the `@access` and `@since` tag should be swapped.
 * There shouldn't be an empty line between `@param` and `@return` tags.
 * A description for `@global wpdb $wpdb` is missing: "WordPress database
 abstraction object."

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34941#comment:23>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform