[wp-trac] [WordPress Trac] #36861: The Insert into post button in the Edit Image window doesn't work.

[WordPress Trac]

#36861: The Insert into post button in the Edit Image window doesn't work.
--------------------------+------------------------------
 Reporter:  tai           |       Owner:  adamsilverstein
     Type:  defect (bug)  |      Status:  assigned
 Priority:  normal        |   Milestone:  4.5.3
Component:  Media         |     Version:  4.5
 Severity:  normal        |  Resolution:
 Keywords:  needs-patch   |     Focuses:  javascript
--------------------------+------------------------------
Changes (by adamsilverstein):

 * owner:   => adamsilverstein
 * status:  new => assigned


Comment:

 Debugging this media code is difficult because of the complexity with
 which events are both registered and triggered.

 Since upgrading Backbone, the handler that updates the 'toolbar' at the
 bottom of the edit image view is never triggered, so the 'Insert into
 Post' button still shows (and doesn't work)... The toolbar is supposed to
 show the 'Back' button,

 [attachment:36861.diff] fixes the issue by changing the way the toolbar
 render is triggered when switching into the image edit mode.

 Previously activate/deactivate were being called when switching to this
 view and these attached and detached (respectively) handlers intended to
 be triggered by the switch to render the correct toolbar - the footer area
 where the back button shows. This is an initial patch and can be further
 cleaned by/simplified removing activate/deactivate entirely and calling
 the render method directly.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36861#comment:4>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform