[wp-trac] [WordPress Trac] #36832: Refactor for class-walker-nav-menu-edit.php

[WordPress Trac]

#36832: Refactor for class-walker-nav-menu-edit.php
-------------------------+-----------------------------
 Reporter:  iamntz       |       Owner:
     Type:  enhancement  |      Status:  closed
 Priority:  normal       |   Milestone:
Component:  Menus        |     Version:  trunk
 Severity:  normal       |  Resolution:  wontfix
 Keywords:  has-patch    |     Focuses:  administration
-------------------------+-----------------------------
Changes (by boonebgorges):

 * status:  reopened => closed
 * resolution:   => wontfix
 * milestone:  Awaiting Review =>


Comment:

 Hi @iamntz - Thanks for the patch.

 We have a policy of not doing major refactoring, except when the refactor
 is necessary to fix bugs or to enable certain kinds of use cases. It looks
 to me like the refactoring you're suggesting doesn't enable anything
 fundamentally new, or fix any bugs, so I'm afraid it's probably off the
 table without further justification. See
 https://make.wordpress.org/core/handbook/contribute/code-refactoring/ for
 more details.

 Out of curiosity, what is the advantage of using `add_action()` to build
 various parts of the UI, rather than simply calling the methods (eg
 `$this->get_menu_item_fields_url_markup()`)?

 If you'd like to propose a fix for #18584, I'd suggest proposing it on
 that ticket. I haven't waded through that ticket's history, but I imagine
 there's a reason why it hasn't been resolved yet :)

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36832#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform