[wp-trac] [WordPress Trac] #34893: Improve Customizer setting validation model

WordPress Trac noreply at wordpress.org
Mon May 16 18:16:57 UTC 2016


#34893: Improve Customizer setting validation model
-------------------------------------------------+-------------------------
 Reporter:  westonruter                          |       Owner:
     Type:  enhancement                          |  westonruter
 Priority:  high                                 |      Status:  accepted
Component:  Customize                            |   Milestone:  4.6
 Severity:  normal                               |     Version:  3.4
 Keywords:  has-patch needs-testing needs-unit-  |  Resolution:
  tests has-screenshots                          |     Focuses:  javascript
-------------------------------------------------+-------------------------

Comment (by mrahmadawais):

 Replying to [comment:36 celloexpressions]:
 > @mrahmadawais the CSS spacing should be correct for the site title
 control, but I didn't check the others. The intent is for `8px` above and
 below the notification, including any margins on adjacent elements.

 I get that, but it doesn't play well with other conditions, as you can see
 in the comment above.

 @westonruter  Here's another suggestion.

 - Error notification inside the widgets area is not looking good. The
 white background of the notification is getting mixed up with the white
 background of widget accordion. This can be solved by moved the error
 message to the top of the chain i.e. before the div with class `widget-
 top` and inside the div with class `widget`. It would look something like
 this

 **Before**
 [[Image(https://i.imgur.com/kDjFdos.png)]]

 **After**
 [[Image(https://i.imgur.com/1q93IGD.png)]]

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34893#comment:37>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list