[wp-trac] [WordPress Trac] #34893: Improve Customizer setting validation model
WordPress Trac
noreply at wordpress.org
Mon May 16 18:05:13 UTC 2016
#34893: Improve Customizer setting validation model
-------------------------------------------------+-------------------------
Reporter: westonruter | Owner:
Type: enhancement | westonruter
Priority: high | Status: accepted
Component: Customize | Milestone: 4.6
Severity: normal | Version: 3.4
Keywords: has-patch needs-testing needs-unit- | Resolution:
tests has-screenshots | Focuses: javascript
-------------------------------------------------+-------------------------
Comment (by mrahmadawais):
@westonruter I just tested the latest patch and here's what I think
- In example plugin, the error being reported is wrong, it should read
`You must supply a Navigation Label` instead of the `title` which begs the
question of building a custom notification renderer which could get back
the fieldname with WP_Error instance.
- CSS Spacing issues are evident almost everywhere with the error
notification. I can contribute on that part but probably it has more to do
with how notifications are being rendered. Check the images attached
below.
- Would it be better if we can designate a certain area for notifications
at the top so that folks building custom controls won't mess up the
notifications
Check the red line to visually differentiate the odd spacing issues.
[[Image(https://i.imgur.com/PNlFzzz.png)]]
[[Image(https://i.imgur.com/JECaqhZ.png)]]
[[Image(https://i.imgur.com/80fIU8b.png)]]
--
Ticket URL: <https://core.trac.wordpress.org/ticket/34893#comment:35>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform
More information about the wp-trac
mailing list