[wp-trac] [WordPress Trac] #34893: Improve Customizer setting validation model

[WordPress Trac]

#34893: Improve Customizer setting validation model
-------------------------------------------------+-------------------------
 Reporter:  westonruter                          |       Owner:
     Type:  enhancement                          |  westonruter
 Priority:  high                                 |      Status:  accepted
Component:  Customize                            |   Milestone:  4.6
 Severity:  normal                               |     Version:  3.4
 Keywords:  has-patch needs-testing needs-unit-  |  Resolution:
  tests has-screenshots                          |     Focuses:  javascript
-------------------------------------------------+-------------------------
Changes (by celloexpressions):

 * priority:  normal => high


Comment:

 [attachment:34893.4.diff] cleans up the CSS a bit, see slightly-revised
 screenshot. One part that needs particular testing - the former `width:
 98%` for all customizer inputs is revised to `100%` so that they will
 align with other elements (such as media controls) and notifications.

 Other thoughts:
 - I would be in favor of injecting at the top of the control when there
 isn't a title unless the custom control overrides the element.
 - Selective refresh seems to revert to the previous setting value when a
 setting is invalid. Perhaps we should do this but also keep it faded/in an
 updating state to indicate that there is a problem with the current
 setting (hence the previous value being used)?
 - We will want to move the notification out of the `<label>` element, but
 let's wait to do that until we do a general cleanup of the `label`
 structure in the customizer, since that will require a broader approach.
 - I think we could probably use the class `.has-notifications` on
 `.customize-control` instead of having both `.customize-control` and
 `.customize-control-has-notifications`.
 - The per-control/setting notifications look pretty good. In terms of an
 overall notifications area, I think it would be helpful in terms of
 usability to aggregate all instances of errors into a single place that
 included autofocusing links to each of the controls with errors. I'll make
 a mockup of that on #35210.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34893#comment:32>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform