[wp-trac] [WordPress Trac] #36590: POST['nav-menu-data'] breaks other POST values

[WordPress Trac]

#36590: POST['nav-menu-data'] breaks other POST values
-------------------------------------+-------------------------------------
 Reporter:  Unyson                   |       Owner:
     Type:  defect (bug)             |      Status:  reopened
 Priority:  normal                   |   Milestone:  4.5.3
Component:  Menus                    |     Version:  4.5
 Severity:  normal                   |  Resolution:
 Keywords:  has-unit-tests has-      |     Focuses:  javascript,
  patch needs-testing                |  administration
-------------------------------------+-------------------------------------

Comment (by ericlewis):

 Tested attachment:36590-trunk.diff, works well.

 I renamed the function `array_merge_recursive()` to
 `_array_merge_recursive()` to test attachment:36590-4.5.2.diff as I don't
 have an easy way to test with a real 5.2 environment. I get a 502, which I
 believe is due to the logic at the beginning of `array_merge_recursive()`
 causing an infinite loop:

 {{{
 #!php
 if ( function_exists( 'array_replace_recursive' ) ) {
     return array_replace_recursive( $base, $replacements );
 }
 }}}

--
Ticket URL: <https://core.trac.wordpress.org/ticket/36590#comment:40>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform