[wp-trac] [WordPress Trac] #36639: Customize: get_custom_logo filter should include blog parameter

WordPress Trac noreply at wordpress.org
Wed May 11 16:20:44 UTC 2016

#36639: Customize: get_custom_logo filter should include blog parameter
 Reporter:  achbed       |       Owner:
     Type:  enhancement  |      Status:  new
 Priority:  normal       |   Milestone:  4.6
Component:  Customize    |     Version:  4.5
 Severity:  normal       |  Resolution:
 Keywords:  has-patch    |     Focuses:

Comment (by flixos90):

 Replying to [comment:4 achbed]:
 > Should we not do the `get_custom_logo` filtering while we're in the
 switched blog scope?  That would allow more consistent results if the
 alternate blog has additional filtering wouldn't it?

 The filter is currently applied outside of the switched blog scope, so we
 should stick with this for backwards compatibility in case someone is
 using the filter at this point. Applying the filter inside the switched
 scope could cause inconsistencies with whatever logic is executed in the
 filter functions.

 Another reason to apply the filter outside of the switched scope is to be
 consistent with `get_site_icon_url`, as stated above.

Ticket URL: <https://core.trac.wordpress.org/ticket/36639#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform

More information about the wp-trac mailing list