[wp-trac] [WordPress Trac] #17904: Multisite has more restrictions on user login character set

[WordPress Trac]

#17904: Multisite has more restrictions on user login character set
--------------------------------------+-------------------------
 Reporter:  duck_                     |       Owner:  jeremyfelt
     Type:  defect (bug)              |      Status:  assigned
 Priority:  normal                    |   Milestone:  4.6
Component:  Login and Registration    |     Version:  3.0
 Severity:  normal                    |  Resolution:
 Keywords:  has-patch has-unit-tests  |     Focuses:  multisite
--------------------------------------+-------------------------
Changes (by ericlewis):

 * keywords:  needs-unit-tests needs-patch => has-patch has-unit-tests


Comment:

 In attachment:17904.4.diff,

 * Explicitly return an error if one is produced in
 `wp_validate_user_login()`. Previously just the `user_login` was being
 returned.
 * unit tests for `wp_validate_user_login()` with pretty good coverage.
 * Remove the 4 character minimum limit.
 * The site option `illegal_names` check should only happen in multisite,
 but the `illegal_logins` filter should stay as that is used in single
 site.
 * Sandbox the restriction that a user login must have one letter to
 multisite, and modified the regex to require an alphabetical letter.

--
Ticket URL: <https://core.trac.wordpress.org/ticket/17904#comment:47>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform