[wp-trac] [WordPress Trac] #34384: No way of preventing image_get_intermediate_size from returning cropped image

WordPress Trac noreply at wordpress.org
Sun May 8 07:06:21 UTC 2016


#34384: No way of preventing image_get_intermediate_size from returning cropped
image
------------------------------------+------------------------
 Reporter:  pputzer                 |       Owner:  joemcgill
     Type:  defect (bug)            |      Status:  reviewing
 Priority:  normal                  |   Milestone:  4.6
Component:  Media                   |     Version:  3.0
 Severity:  normal                  |  Resolution:
 Keywords:  has-patch dev-feedback  |     Focuses:
------------------------------------+------------------------

Comment (by pputzer):

 I missed the Slack chat, but some comments on the issues raised by
 @joemcgill:

 * `$force_thumb` enables the current behavior, so having it set to `true`
 by default ''ensures'' backward compatibility. It is probably true that a
 filter would be needed as well for certain situations.
 * However, I think a parameter should also stay so that direct callers
 don't have to create filter functions for this (filters make the code much
 less obvious IMHO).

--
Ticket URL: <https://core.trac.wordpress.org/ticket/34384#comment:6>
WordPress Trac <https://core.trac.wordpress.org/>
WordPress publishing platform


More information about the wp-trac mailing list